Phone sounds update #6789
Merged
Phone sounds update #6789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Sound
|
Ngl I like this PR |
realforest2001
approved these changes
Jul 30, 2024
Drulikar
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
There maybe could be better sound ending behavior (longer sounds ought to be interrupted immediately on hangup for example) but its not terrible. Feel free to revisit in the future if you care.
Also its weird that the speaker gets to_chat messages from the phone when they are speaking into the phone (as if they are hearing themselves on the line) but thats unrelated to this PR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds sounds for:
Someone pick up phone on other end
Someone hung up phone on other end
Someone talk on the other end
Reaching voicemail
Dialing
Typing dial numbers
Post call disconnection beeps
(video volume is a bit low, just high it up, they are loud enough in game)
dreamseeker_yLHwKtrt8m.mp4
dreamseeker_jssosipgoJ.mp4
All sounds are either from public domain or custom made.
For discusstion about sound origin see https://discord.com/channels/150315577943130112/964684928161808384/1266875925916680253
Explain why it's good for the game
More immersion and atmosphere.
Changelog
🆑
soundadd: added numerous phone sounds for different phone interactions
/:cl: